feat: add Windows support for socket communication#44
Closed
tucaman wants to merge 1 commit intonicobailon:mainfrom
Closed
feat: add Windows support for socket communication#44tucaman wants to merge 1 commit intonicobailon:mainfrom
tucaman wants to merge 1 commit intonicobailon:mainfrom
Conversation
Replace hardcoded /tmp/surf.sock Unix socket paths with platform-conditional logic that uses Windows named pipes (\.\pipe\surf-sock) on win32 and os.tmpdir() on Unix. Also fixes the LOG_FILE path in host.cjs to use os.tmpdir() on Windows instead of the non-existent /tmp/ directory. Files changed: - native/cli.cjs: SOCKET_PATH - native/do-executor.cjs: SOCKET_PATH + added os/path imports - native/host.cjs: SOCKET_PATH + LOG_FILE - native/mcp-server.cjs: SOCKET_PATH + added os/path imports
Owner
|
Closing in favor of #39 which covers the same ground plus ImageMagick quoting, unlinkSync/chmodSync skip, temp file routing, and network-store paths. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp/surf.sockUnix socket paths with platform-conditional logic\.\pipe\surf-sock) onwin32,os.tmpdir()on UnixLOG_FILEinhost.cjsto useos.tmpdir()on Windowsosandpathimports todo-executor.cjsandmcp-server.cjsFixes #43
Related to #42 (same user-facing error, different root cause — Windows path vs macOS socket creation)
Changes
4 files in
native/:cli.cjsSOCKET_PATH→ platform conditionaldo-executor.cjsSOCKET_PATH→ platform conditional + addedos/pathimportshost.cjsSOCKET_PATH+LOG_FILE→ platform conditionalmcp-server.cjsSOCKET_PATH→ platform conditional + addedos/pathimportsTest plan
surf tab.listconnects and returns Chrome tabsos.tmpdir()which returns/tmpon Linux/macOS)